Use grouped operation name in application insights telemetry #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
reviewed
Apr 19, 2024
src/Tracing/ApplicationInsights.AspNetCore/OperationNameTelemetryInitializer.cs
Outdated
Show resolved
Hide resolved
tomasherceg
approved these changes
Apr 27, 2024
|
Many thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application insights request telemetry on DOTVVM pages is identified by request URL. If there are path variables app insights considers them as different operations and does not apply grouping. Results are hard to read with tables consisted of many rows pointing to the same route.
I was inspired by Web API where operation name ignores variables and used DOTVVM route URL as new name. I was also considering DOTVVM route name, but from my experience URL is always provided by problem reporter (imagine non IT users as reporters) but route name can be more problematic to guess at first look.
As you can see on second screenshot "vyuctovanie" was grouped and I can see overal behavior of this page.